Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addition: addition to inventory check at resource start #522

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

addition: addition to inventory check at resource start #522

wants to merge 3 commits into from

Conversation

LeSiiN
Copy link

@LeSiiN LeSiiN commented May 27, 2024

  • Showcase Video: https://youtu.be/5yYuwbX_A2c after the inventory started, it checks every inventory. If the inventory got nothing inside ( empty ) it deletes the database line.
  • So it keeps it organized and optimised

Checklist

  • [x ] I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • [x ] My code fits the style guidelines.
  • [x ] My PR fits the contribution guidelines.

@LeSiiN
addition to inventory check at resource start
d7eb826 
- Showcase Video: https://youtu.be/5yYuwbX_A2c
after the inventory started, it checks every inventory. If the inventory got nothing inside ( empty ) it deletes the database line.
- So it keeps it organized and optimised
@LeSiiN LeSiiN changed the title addition to inventory check at resource start addition: addition to inventory check at resource start May 27, 2024
@t0r3tto
Copy link
Contributor

t0r3tto commented May 27, 2024

imo they should not even interact with the DB (insert empty data) if empty since it's pointless, essentially this fixes an issue which shouldn't exist in the first place

@LeSiiN
Copy link
Author

LeSiiN commented May 27, 2024

imo they should not even interact with the DB (insert empty data) if empty since it's pointless, essentially this fixes an issue which shouldn't exist in the first place

u totally right.

@GhzGarage GhzGarage self-assigned this Jul 25, 2024
@GhzGarage GhzGarage added enhancement New feature or request help wanted Extra attention is needed labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GhzGarage GhzGarage

@LeSiiN LeSiiN

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeSiiN @t0r3tto @GhzGarage